out_batches not being set in transform_input_data() with cos_norm_out=False

chriscainx / mnnpy

An implementation of MNN (Mutual Nearest Neighbors) correct in python.

BSD 3-Clause "New" or "Revised" License

71 stars 31 forks source link

out_batches not being set in transform_input_data() with cos_norm_out=False #10

Open ktpolanski opened 6 years ago

ktpolanski commented 6 years ago

Hello,

For whatever reason, I feel more comfortable running mnn_correct() with cos_norm_out set to False. As such, I tried to do it this way, and got an error about out_batches not being set. Looking at the source code of transform_input_data(), out_batches only gets set if cos_norm_out is set to True. Just bringing this to your attention, as in its current form an input flag kills the function.

chriscainx commented 6 years ago

Thank you! I will look into it. If you have a direct fix, you are welcome to submit a pull request!

wangjiawen2013 commented 6 years ago

I meet this error too!