search

chriscamicas / vscode-abl

An extension for VS Code which provides support for the Progress OpenEdge ABL language. https://marketplace.visualstudio.com/items?itemName=chriscamicas.openedge-abl
MIT License
50 stars 37 forks source link

add autocomplete for tables, fields, methods #51

Closed RobinHerbots closed 4 years ago

RobinHerbots commented 4 years ago

Hi @chriscamicas , @ezequielgandolfi,

I was trying out some abl extensions for vscode. What I saw where seperate efforts which are all based on each others. The one has things straight, which another lacks, and vice-versa.

What I especially liked about your plugin @chriscamicas was the run and debug implementation. On the plugin from @ezequielgandolfi i liked the autocomplete for database tables and implementation of the different providers for vscode.

So I decided to merge the features. A first result can be seen in this PR.
I added all the providers and database table/field support from openedge-zext. Also hovering etc gives info.

I hope you like it and merge it. Otherwise I create a separate fork and invite all to collaborate on this.

RobinHerbots commented 4 years ago

@chriscamicas ,

The errors you see are linter errors, ... I disabled them temporarely, ... these still need to be resolved or relaxed ;-)

chriscamicas commented 4 years ago

Hey, welcome onboard ! Thank you very much for your contribution. I'd be happy to merge your modifications, but I'd rather have the lint error fixed before. Do you mind fixing them ? Thanks again

RobinHerbots commented 4 years ago

@chriscamicas ,

;-) Thank you!

No problem I will fix the linting errors and update the PR.

How about the implementation of the LSP? Is this going somewhere?

RobinHerbots commented 4 years ago

Hi @chriscamicas ,

I fixed the tslint errors, ... I see that tslint is deprecated and will be phased out. Maybe switch to eslint as recommended?

chriscamicas commented 4 years ago

There is no WIP for an LSP implementation However I'm convinced it's the right solution. If you are willing to explore this path, you have my full support.

chriscamicas commented 4 years ago

I fixed the tslint errors, ... Thanks

I see that tslint is deprecated and will be phased out. Maybe switch to eslint as recommended? Great idea, here is a new issue to track that #55

mimorocks commented 4 years ago

isn't this ready to be merged?

chriscamicas commented 4 years ago

It is ready to be merged, I just need some time to rebuild my setup and publish the extension. Sorry for that. BTW if someone's interested in becoming a contributor I'm looking for valuable members to help me maintain this extension as I have less time available.