chrischabot / opensocial-python-client

Automatically exported from code.google.com/p/opensocial-python-client
Apache License 2.0
0 stars 0 forks source link

split_url_string discards empty arguments #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. call OAuthRequest.from_request from a script called by makeRequest from
partuza.nl
2. split_url_string discards empty args such as oauth_token=
3. get_normalized_parameters will return a string without empty args

What is the expected output? What do you see instead?
A string with empty args so that it matches the string used by partuza to
create the signature.

What do you see instead?
I see a string without empty args.

What version of the product are you using? 
0.3.0
On what operating system?
Debian GNU/Linux

Please provide any additional information below.

The attached patch fixes the problem

Original issue reported on code.google.com by loic-goo...@dachary.org on 17 Jul 2009 at 9:28

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch!  I'll commit this since it's such a minor change, but I'd 
love to see 
a unit test added for this case, so that we can be sure that this fix remains 
working in 
the future.

Original comment by api.kurrik%google.com@gtempaccount.com on 17 Jul 2009 at 5:01

GoogleCodeExporter commented 9 years ago
Thanks for applying the patch. I don't know where to begin to write such tests.
Having tests that depend on the health of external services is troubling me 
(i.e.
tests need to access the net). 

Original comment by loic-goo...@dachary.org on 17 Jul 2009 at 5:04

GoogleCodeExporter commented 9 years ago
Applied in r48

Original comment by api.kurrik%google.com@gtempaccount.com on 17 Jul 2009 at 5:05