Implement GitHub Actions for automated version bump

chriscrowe / docker-pihole-unbound

Run Pi-Hole + Unbound on Docker

1.05k stars 274 forks source link

Implement GitHub Actions for automated version bump #171

Open danieled-it opened 1 year ago

danieled-it commented 1 year ago

Hey @chriscrowe , I've been a big fan and user of your one-container solution for a while now, and recently got interested in GitHub Actions.

Before randomly sending you a PR, I was wondering if you'd be interested in automating the process of:

Check the latest version of pihole/pihole
If pihole/pihole:latest is newer than cbcrowe/pihole-unbound:latest bump the version in this repo
Trigger build and push of new latest and YYYY.MM.N (following pihole's tags)
(Optional?) Create a tag in repo out of the newly committed version

I understand it's better to check the release notes of the latest pihole releases to make sure that you don't just blindly go and +1 it, but again if you think you'd like the idea just let me know.

tritethunder commented 1 year ago

Much needed step.

pluim003 commented 1 year ago

This is indeed nice. After reading your post @danieled-it I started to implement it in my fork to update a nightly-image through a scheduled task on my Windows-laptop. Also made one for latest (with no respect of version number then as I'm not aware of the new version-number yet).

I'm not familiar with Github Actions yet.

And ofcourse this morning a new release and had modified the script to check for a latest and then recreate the stuff but due to a typo this didn't work as designed from the taskscheduler, so had to do it manually. A new one is available now.

tritethunder commented 1 year ago

@chriscrowe I added a PR to mitigate this issue. where the build triggers daily and in case we have a new image it will create and push the new image and bump the tags in the docker registry.

pluim003 commented 1 year ago

@chriscrowe I added a PR to mitigate this issue. where the build triggers daily and in case we have a new image it will create and push the new image and bump the tags in the docker registry.

I tried your suggestion in my fork. It took a while and stumbled on a 'typo'. Somewhere in your yml-file it says platform: linux/arm64/etc, but that didn't do the trick. Had to change it to the plural platforms.