search

chriscrowe / docker-pihole-unbound

Run Pi-Hole + Unbound on Docker
1.08k stars 282 forks source link

Replace deprecated variables #82

Closed xaabi6 closed 2 years ago

xaabi6 commented 3 years ago

DNS1 and DNS2 environment variables are deprecated as per pi-hole official documentation, PIHOLEDNS should be used instead.

xaabi6 commented 3 years ago

In the single container version, I have decided to keep both DNS, but as far as I know, we could define just one.

The change to be made would be as follows:

PIHOLE_DNS_: 127.0.0.1#5335 # Hardcoded to our Unbound server

Please, tell me if you want me to change it 😄

PromoFaux commented 3 years ago

but as far as I know, we could define just one.

Yep, that should be correct. Having to define at least 2 DNS servers is no longer necessary

xaabi6 commented 3 years ago

but as far as I know, we could define just one.

Yep, that should be correct. Having to define at least 2 DNS servers is no longer necessary

Change done 👍

chriscrowe commented 2 years ago

Thanks -- I'm incorporating this with some other syntax tweaks in the next update.