search

chriscrowe / docker-pihole-unbound

Run Pi-Hole + Unbound on Docker
1.06k stars 276 forks source link

formatting updates to environment syntax #86

Closed gramsaran closed 2 years ago

gramsaran commented 2 years ago

environment variable should be = not . Also updated PIHOLEDNS from DNS1

mhmatthewhugley commented 2 years ago

This formatting change seems to cause errors with portainer 2.9.2. Please do not merge this pull request cause then people using portainer would have to figure out how to revert back to the old formatting. This format might work with docker compose version 3 but it does not seem to work with version 2.

mhmatthewhugley commented 2 years ago

The error seems to be resolvable if the comment on line 28 is removed. Some sort of issue with indentation according to portainer.

chriscrowe commented 2 years ago

Good catch on the syntax, I'll merge this and remove the comments.