search

chrisdancee / react-ios-pwa-prompt

A native styled 'Add to Home Screen' React component for PWAs on iOS
react-ios-pwa-prompt.vercel.app
175 stars 41 forks source link

Typescript #49

Open keonik opened 4 years ago

keonik commented 4 years ago

Hey everyone! I just wanted to say I love this library. Use it at work and in my personal projects. I'm gaining some familiarity with typescript and would love to get some of the typescript perks in it. I know this is coming out of nowhere so feel free to shut it down or give some feedback.

chrisdancee commented 4 years ago

Hi @keonik

Thanks a lot for the contribution - I really appreciate the TS overhaul! I have merged a couple of things, so I will get this PR up to date and add typings for the additional props.

EDIT: Just having a look through your PR now. The level of effort you've gone to here is phenomenal. Thank you so much!

keonik commented 4 years ago

🙏 It will be a huge help for a few of my personal applications. Happy to contribute!

transmissions11 commented 4 years ago

@chrisdancee I could really benefit from this as well!

keonik commented 4 years ago

@chrisdancee @TransmissionsDev I caught this up with what I saw on comparison with master. All I noticed was the onClose handler. Let me know if I missed something. Is there anything I can do to help with the review?

shihfu commented 3 years ago

Any updates on this pull request? Would love to use this on a new TS project.

thenick775 commented 11 months ago

Bump

thenick775 commented 11 months ago

For anyone looking for typescript support, I've published a fork here that bundles its own typings:

https://www.npmjs.com/package/react-ios-pwa-prompt-ts