chrisdanford / grunt-ver

MIT License
19 stars 15 forks source link

refrences regex doesn't escape '.' #2

Open stuartf opened 11 years ago

stuartf commented 11 years ago

When doing the substitutions in references the regex looks like:

regex = new RegExp('\\b' + to.basename + '\\b', 'g');

So if you have a basename like foo.js and a path like /foo/js/bar.js the foo/js will be replaced when it shouldn't. Before building that regex it would be safer to escape all the regex special characters from to.basename, someone on StackOverflow has even already written a regex to do that: http://stackoverflow.com/questions/3561493/is-there-a-regexp-escape-function-in-javascript/3561711#3561711

noahrc commented 10 years ago

+1 this fixed the problems I was having with the regex

jwagner commented 9 years ago

Ran into this issue too, would be cool if this could be merged.