search

chrisdavies / tiny-date-picker

A small, modern, dependency-free date picker
https://chrisdavies.github.io/tiny-date-picker/
415 stars 87 forks source link

add dispose method on date-range-picker #64

Closed cameronbraid closed 6 years ago

cameronbraid commented 6 years ago

having played with the API, it appears that there is no dispose method on tiny-date-picker

chrisdavies commented 6 years ago

Curious why you closed this. Did you come up with a workaround?

cameronbraid commented 6 years ago

when I ran my code that called the dispose method on the date range picker, I received an error saying start.dispose is not defined. The method is actually called destroy

chrisdavies commented 6 years ago

Ha! I forgot that I had that in there. :)

cameronbraid commented 6 years ago

The date range picker doesn't need a destroy method, since it uses the date picker in permanent mode which uses dp.destroy = noop