search

chrisdavies / tiny-date-picker

A small, modern, dependency-free date picker
https://chrisdavies.github.io/tiny-date-picker/
415 stars 87 forks source link

#94 - permanent-mode destroy should not be a noop #95

Closed cnatis closed 5 years ago

cnatis commented 6 years ago

Permanent mode destroy should not be overridden, destroy() in base mode will handle closing the UI and removing input event handlers. We dont need to override destroy() because we have already overridden close()

chrisdavies commented 5 years ago

Thanks for the PR. It's a good catch!