search

chrisdebian / MOROW

"Maintaining Our Rights of Way"- An initiative, initially for the UK, to encourage use, discovery, mapping and reporting of Public Rights of Way (PRoW).
7 stars 0 forks source link

TECHDEBT-Upgrade to oauth2 #2

Open chrisdebian opened 2 months ago

chrisdebian commented 2 months ago

Nick has done some brilliant work to get his unmaintained code working https://gitlab.com/nickw1/mapthepaths-android/-/commits/morow-investigation. A couple of things need to be updated, and one of these is oauth2.

Can anyone with the appropriate skills, help to implement oauth2; this would be a change from the deprecated oauth that is currently implemented.

Many thanks,

Chris.

nickw1 commented 2 months ago

Have had a quick look for libraries to write an OAuth2 client in Android and have come up with this one from OpenID which looks promising:

https://github.com/openid/AppAuth-Android

I could almost certainly implement this, though I don't want to promise as it's dependent on my time availability.

chrisdebian commented 2 months ago

Hi, Nick.

All 'comers' are welcome. If you get a chance to give it a try, perfect! Don't think this is 'on you', though.

Thank you for anything you can manage.

Chris

chrisdebian commented 2 months ago

Nick,

If oath2 is implemented, in the future, would this automatically satisfy the OSM login requirement?

Just trying to avoid creating duplicate issues.

Thanks,

Chris

nickw1 commented 2 months ago

Chris - yes it would. The OAuth protocol is used to login to OSM: third-party OSM logins now require oauth2, the old oauth1 protocol is no longer supported.