search

chrisdesilva / pickup

App for finding nearby basketball courts for pickup games
MIT License
14 stars 28 forks source link

Weather should only display on outdoor courts #31

Open chrisdesilva opened 5 years ago

chrisdesilva commented 5 years ago

As some courts are indoors, only show weather for outdoor courts

dishankmehta commented 5 years ago

Hey, I am interested in doing this.

chrisdesilva commented 4 years ago

Assigned!

dishankmehta commented 4 years ago

Hey @chrisdesilva , I started working on this today and I keep getting this error. Any idea?

TypeError: _fire__WEBPACK_IMPORTED_MODULE_4__.default.collection is not a function

chrisdesilva commented 4 years ago

I was having that issue as well and realized that the Google Maps API environment variable in my .env didn't match the name in the AddCourt component. Someone submitted a PR that fixed the problem. Check the environment variable first and if that doesn't solve the issue, try forking/cloning from scratch.

dishankmehta commented 4 years ago

Hey pulling the latest changes solved the issue. I had one question that currently we do not have a field indicating that the court is indoor or outdoor should I add that?

chrisdesilva commented 4 years ago

Awesome! An indoor/outdoor field would be great as well.

dishankmehta commented 4 years ago

Hey @chrisdesilva, I have submitted the pull request for this issue.