chrisdew / protobuf

Protocol Buffers for Node.JS
http://code.google.com/p/protobuf-for-node/
Apache License 2.0
234 stars 70 forks source link

Switch to node-gyp, bundle the protobuf library, support Windows #15

Closed seishun closed 12 years ago

seishun commented 12 years ago

This module currently requires protobuf libraries installed globally on the system, which makes it unusable on hosting services that don't provide root access such as Heroku. Moreover, it's completely unusable on Windows because it uses node-waf.

I've fixed both problems by bundling the protobuf library as used in Chromium (the official release doesn't have a gyp file) with compiler, Python files and unit tests removed.

The includes in protobuf_for_node.cpp are shifted around to prevent a redefinition issue introduced by Windows headers.

chrisdew commented 12 years ago

Thanks, I'll test this out.