search

chrisdew / protobuf

Protocol Buffers for Node.JS
http://code.google.com/p/protobuf-for-node/
Apache License 2.0
234 stars 70 forks source link

Added a Visual Studio 2013 build error fix from the official repository #38

Closed looterz closed 10 years ago

looterz commented 10 years ago

Implemented the fix from revision 512 of the official SVN repository on google code that allows Visual Studio 2013 to build protobuf without issues.

Source: https://code.google.com/p/protobuf/issues/detail?id=531

looterz commented 10 years ago

Added one more change to this branch, that completely fixes all build errors Visual Studio 2013 was generating for me.

chrisdew commented 10 years ago

Can a second pair of eyes (with a Windows machine) try building this before I merge?

looterz commented 10 years ago

Guess nobody else has a windows machine? damn.

chrisdew commented 10 years ago

I'll make sure this doesn't break the Linux build next week, and merge if it's OK.

looterz commented 10 years ago

Alright cool. This issue was the only problem I had when working with a project using node-protobuf a few months ago on a windows box, I figured I would submit the fix because its bound to happen to someone else eventually, thankfully the guys on google-groups already fixed it though.