search

chrisdew / protobuf

Protocol Buffers for Node.JS
http://code.google.com/p/protobuf-for-node/
Apache License 2.0
234 stars 71 forks source link

Add support for node.js v0.11.13 / v0.12 #41

Closed billmark closed 10 years ago

billmark commented 10 years ago

The protobuf module does not build with node.js v0.11. I just tried it with v0.11.13 which apparently is fairly close to what we'll get for node v0.12

The problem is that there have been changes to node and v8's interfaces for native code. A good summary of what's changed is at https://github.com/rvagg/nan (That site is actually a library which might be helpful in dealing with the issues).

Does anyone have plans to work on this?

mikepb commented 10 years ago

Started on this, but it segfaults running the test. https://github.com/mikepb/protobuf

I'm going to use @dcodeIO's ProtoBuf.js now... https://github.com/dcodeIO/ProtoBuf.js

chrisdew commented 10 years ago

No, I am giving up maintenance of this project.

billmark commented 10 years ago

Nikolai Vavilov has just completed a port of protobuf to node 0.11.13 which is at: https://github.com/seishun/protobuf/tree/0.12

mikepb commented 10 years ago

I used rvagg/nan for backwards compatibility, but I'm giving up on this too...

imkira commented 10 years ago

Just to let you know https://github.com/chrisdew/protobuf/pull/43 Any feedback (especially tests :) is highly appreciated.

chrisdew commented 10 years ago

We have a couple of candidates for v0.11.x support, including https://github.com/chrisdew/protobuf/pull/43

I will have a look at them both in the next couple of days and provide feedback if I find any issues.

chrisdew commented 10 years ago

I've merged #43.