search

chrisdhaan / CDMarkdownKit

An extensive Swift framework providing simple and customizable markdown parsing.
MIT License
254 stars 66 forks source link

Fix implicitly final warnings #14

Closed ismyhc closed 6 years ago

ismyhc commented 6 years ago

Goals :soccer:

Fixed warnings 'let' properties are implicitly 'final'; use 'public' instead of 'open'

The warnings in my project were driving me crazy :) I decided to fix and make a pull request rather than asking someone to do it.

ismyhc commented 6 years ago

@chrisdhaan any chance we could get this merged? Id love to get rid of the warnings in my project :)

chrisdhaan commented 6 years ago

@ismyhc thank you for pointing this out. Let me take a look and see if I want to switch them to public or vars but I'll get to it within the next 24 hours.

ismyhc commented 6 years ago

@chrisdhaan great! Thanks 😀

ismyhc commented 6 years ago

@chrisdhaan just checking to see if you had a chance to either merge the pull request or fix? Id love to get rid of the warnings in my project :)

chrisdhaan commented 6 years ago

@ismyhc your PR has been merged in. I'm doing a little more cleanup on the project and will release a new version tomorrow.

ismyhc commented 6 years ago

@chrisdhaan Okay, great! Looking forward to it!