chrisdhaan / CDMarkdownKit

An extensive Swift framework providing simple and customizable markdown parsing.

MIT License

254 stars 65 forks source link

Add conditional compile directives to support Swift 4.2 #16

Closed edwardmp closed 5 years ago

edwardmp commented 5 years ago

Issue Link :link:

15

Goals :soccer:

Achieve compatibility with Swift 4.2 while simultaneously keep support for Swift 4.0 and earlier versions.

Implementation Details :construction:

Add some new conditional compile directives that execute code only when it is compiled on Swift 4.2 (+).

Testing Details :mag:

I did not add any extra tests.

edwardmp commented 5 years ago

Not sure why CI is failing on iOS only. Example runs fine with those versions locally.

chrisdhaan commented 5 years ago

@edwardmp thank you for opening up this pull request. This helps me better see what the problem you're experiencing is. I'm going to implement the fix a little differently. I should be able to get to it some time next week after the holiday.

edwardmp commented 5 years ago

@chrisdhaan sure. Might be better to only support Swift 4.2+ going forward.

chrisdhaan commented 5 years ago

@edwardmp I am releasing 1.2.1 with 4.2. support. I'm going to close out this PR.