chrisdhaan / CDMarkdownKit

An extensive Swift framework providing simple and customizable markdown parsing.
MIT License
254 stars 66 forks source link

#26. Add possibility to use multiple \n in a row. #27

Closed MatyashDen closed 2 years ago

MatyashDen commented 4 years ago

Add possibility to use multiple \n in a row

MatyashDen commented 3 years ago

@chrisdhaan would be great if you could review this PR

delarge77 commented 3 years ago

@MatyashDen Good you did it ! Unfortunately no one approved it yet !

chrisdhaan commented 3 years ago

@MatyashDen can you send me an example string that this fixes for you so I can also test the changes prior to merging?

MatyashDen commented 3 years ago

@chrisdhaan Here it is: Hello \n\n World By default library changed string to Hello \n World But after my PR with shouldSquashEndlines equal to false it will do nothing with this string

kimrypstra commented 2 years ago

Hi @chrisdhaan, and chance of a review/merge for this PR? Let me know if I can help out in any way 👍

chrisdhaan commented 2 years ago

@MatyashDen @delarge77 @tarrouye @kimrypstraHE sorry for the delay in getting this functionality into the project. Added with PR #38 and available in version 2.3.0

kimrypstra commented 2 years ago

@chrisdhaan That's great, thank you!