search

chrisdhaan / CDYelpFusionKit

An extensive Swift wrapper for the Yelp Fusion API.
MIT License
54 stars 18 forks source link

Update to Newer Version of AlamofireObjectMapper/Swift 4.2 Compatibility #14

Closed davecom closed 5 years ago

davecom commented 6 years ago

Currently, the podspec ties CDYelpFusionKit to version 5.0.0 of AlamofireObjectMapper, but this has sub-dependencies that are incompatible with the latest version of Swift (4.2) as found in Xcode 10. It would be great if we can get a version of CDYelpFusionKit tied to the latest version of AlamofireObjectMapper, or more generally a version with sub-dependencies that works with Swift 4.2

chrisdhaan commented 5 years ago

@davecom thanks for pointing this out. I'll update this weekend.

chrisdhaan commented 5 years ago

@davecom the update has been merged in to master. I'm doing some more cleanup on the project and will release a new version tomorrow.

davecom commented 5 years ago

Thank you, Chris! Much appreciated.

SylvieLiu commented 5 years ago

hi Chris,

I'm trying to run the code from git on swift 4.2, and it says "No such module 'Alamofire'". I tried with commenting the line "import Alamofire", and it seems that all the dependencies are missing for some reason. I'm quite new to swift, is there anything that I'm doing wrong? Thanks in advance.

screenshot 2018-11-09 at 16 11 23 screenshot 2018-11-09 at 16 19 34
davecom commented 5 years ago

Hi @SylvieLiu, You need to install CDYelpFusionKit using a package manager like CocoaPods or Carthage. Please see the Installation directions in the README. If you install via a package manager, it will install all of the dependencies like Alamofire. Hope this helps!

SylvieLiu commented 5 years ago

Hi @SylvieLiu, You need to install CDYelpFusionKit using a package manager like CocoaPods or Carthage. Please see the Installation directions in the README. If you install via a package manager, it will install all of the dependencies like Alamofire. Hope this helps!

Thanks for the quick response @davecom .

I created a pod and add the line "pod 'CDYelpFusionKit', '~> 1.5'" to each target, I also tried to clean up the project and rebuild. However, it doesn't help, the modules are still missing for some reason.

I also tried to integrate it the Kit in a empty project, it builds successfully. However, the frameworks appear red, and I'm getting "nw_proxy_resolver_create_parsed_array PAC evaluation error: NSURLErrorDomain: -1003" error in my console log. Is it normal?

screenshot 2018-11-09 at 17 15 32 screenshot 2018-11-09 at 17 16 12
davecom commented 5 years ago

I assume you are opening the workspace file and not the regular xcproject file?

SylvieLiu commented 5 years ago

I assume you are opening the workspace file and not the regular xcproject file?

@davecom Hi David, that's unfortunately not the cause of the problem:/

chrisdhaan commented 5 years ago

This has been completed in version 1.5.1. Closing issue.