Support Swift 4 by upgrading AlamofireObjectMapper to 5.0

chrisdhaan / CDYelpFusionKit

An extensive Swift wrapper for the Yelp Fusion API.

MIT License

54 stars 18 forks source link

Support Swift 4 by upgrading AlamofireObjectMapper to 5.0 #4

Closed xixinjie closed 6 years ago

xixinjie commented 6 years ago

What did you do?

Tried to install this lib via CocoaPods as per the guides, and use it in my app.

What did you expect to happen?

Able to install and use

What happened instead?

Able to install but failed to use it, with error: toIntMax unavailable Please find related issue in ObjectMapper

It should work in swift 4 via upgrading AlamofireObjectMapper to 5.0 which support Swift 4.0

CDYelpFusionKit Environment

CDYelpFusionKit version: 1.1.0 Xcode version: 9.0 Swift version: Apple Swift version 4.0 (swiftlang-900.0.65 clang-900.0.37) Platform(s) running CDYelpFusionKit: MacOS macOS version running Xcode: 10.12.6

Demo Project

None

Oh man, it's better to have freestyle issue.

chrisdhaan commented 6 years ago

Hey @xixinjie . I'm working on updating to Swift 4 this week. I'm hoping to have 2.0.0 out by the end of the weekend.

xixinjie commented 6 years ago

Thank you @chrisdhaan . When it's done, I will change from submodule to Cocoapods to install the lib.

chrisdhaan commented 6 years ago

@xixinjie

Here's an update from this weekend. I just finished up 1.2.0 which I'll be releasing tonight. 1.2.0 contains the rest of the frameworks core functionality. Over the next two days I'll be releasing 1.3.0 which contains macOS, watchOS, and tvOS support. I want to get all of this in for full backwards compatibility for Swift 3 users. Hopefully if this all goes well I'll be pushing 2.0.0 on Wednesday which will be Swift 4 ready.

chrisdhaan commented 6 years ago

@xixinjie I have started updating to Swift 4.0. Hoping to have 2.0.0 out within the next 24 hours.

xixinjie commented 6 years ago

@chrisdhaan Thank you man.

xixinjie commented 6 years ago

Ah, glad that you commited the changes for Swift 4.0. Looking forward to having it (1.4.0) released.

chrisdhaan commented 6 years ago

@xixinjie just finishing up some last documentation today and releasing 1.4.0 tonight.

xixinjie commented 6 years ago

@chrisdhaan Looks like not released yet due to build failure

chrisdhaan commented 6 years ago

@xixinjie 1.4.0 has been released. Please try installing and let me know how it works.

xixinjie commented 6 years ago

@chrisdhaan 👍 👍 👍 It works perfectly in Swift 4.0 now. Thank you so much.

BTW, minor changes from 1.3.0 to 1.4.0:

CDYelpCategoryFilter changed to CDYelpBusinessCategoryFilter
Block parameters in searchBusiness changed from (response, error) to (response)

chrisdhaan commented 6 years ago

@xixinjie thanks for pointing out those changes. I'll update the CHANGELOG.md. Afterwards to I have your permission to close out this issue?

xixinjie commented 6 years ago

@chrisdhaan Sure, please close it then.