search

chrisdinn / brando

A Redis client written with Akka's IO package
Other
107 stars 24 forks source link

Added Sentinel support #46

Closed damienlevin closed 9 years ago

damienlevin commented 9 years ago

Added SentinelClient Added BrandoSentinel Connection is now in a separate file Config is pulled from the companion objects

damienlevin commented 9 years ago

Based on the suggestions I had, I added ConnectionSupervisor.scala to capture the common logic of Brando and BrandoSentinel.

Let me know if you prefer that rather than the solution here : https://github.com/damienlevin/brando/tree/sentinel_wip3

damienlevin commented 9 years ago

I wasn't considering dropping the stashing as part of this CL but I'll be more than happy to do it. This should be handled by the application not the library.

chrisdinn commented 9 years ago

Big milestone!

KarelCemus commented 8 years ago

Dropping stash should be documented. It took me a few hours to find why Brando behaves that much different than in version 2.0.2 I used so far. I was not expecting this.

I think that it would be nice to propose how to quickly fix this new behavior without significant application rewrite.

Thanks!