chrisdonahue / nesmdb

The NES Music Database: use machine learning to compose music for the Nintendo Entertainment System!
MIT License
455 stars 39 forks source link

use the latest source code of vgmplay for compiling #14

Open XiaoxiMao opened 2 years ago

XiaoxiMao commented 2 years ago

This commit fixes the compiling error when installing the vgmplay by cloning the latest source code. In the original 0.40.8 version source code of vgmplay, the VGMPlay_AddFmts.c and VGMPlay.c defines 'VGMEnd' twice so the compiler will throw an error saying:

/usr/bin/ld: obj/VGMPlay_AddFmts.o:(.bss+0x4): multiple definition of `VGMEnd'; obj/VGMPlay.o:(.bss+0x2a): first defined here collect2: error: ld returned 1 exit status

To fix the error, simply adding an 'extern' for 'VGMEnd' in the VGMPlay_ADDFmts.c can do it. It was done in a commit of 2020, which is not included in any released package of source code. So I have to clone the latest source code to make the compilation done.