search

chrisdrackett / react-mapkit

React wrapper for Apple's mapkit.js.
https://chrisdrackett.github.io/react-mapkit/?selectedStory=all%20props&full=0&addons=1&stories=1&panelRight=1&addonPanel=storybooks%2Fstorybook-addon-knobs
MIT License
76 stars 26 forks source link

Bump dependencies? #37

Closed pdugan20 closed 4 years ago

pdugan20 commented 4 years ago

Getting warnings for react and react-dom because I'm using 16.13.X: react-mapkit@0.6.3 requires a peer of react@16.8.x but none is installed. You must install peer dependencies yourself.

Can you bump these please?

chrisdrackett commented 4 years ago

should be fixed in 0.6.4, let me know if that does not work!

pdugan20 commented 4 years ago

Thanks man!

pdugan20 commented 4 years ago

Actually you know, I'm now getting the following error: Attempted import error: 'Map' is not exported from 'react-mapkit'

I downgraded back to 0.6.3 and it works fine. Any ideas?

chrisdrackett commented 4 years ago

hm, I'll look into it, maybe something went wrong during the build

chrisdrackett commented 4 years ago

@pdugan20 can you try 0.6.5 and see if that fixes things?

pdugan20 commented 4 years ago

That's working great! Thanks for the quick responses!

chrisdrackett commented 4 years ago

sorry about that, I hope to give this project some love soon, I haven't been doing much map work recently!

pdugan20 commented 4 years ago

Oh no worries at all. I brute forced it into working with polylines. Would love to help out if you need it!

chrisdrackett commented 4 years ago

Nice! I have a bunch of work on overlays that I really do need to finish up and push. Hopefully that provides a good framework for me or others to do things like polylines and similar!