search

chrisdrackett / react-mapkit

React wrapper for Apple's mapkit.js.
https://chrisdrackett.github.io/react-mapkit/?selectedStory=all%20props&full=0&addons=1&stories=1&panelRight=1&addonPanel=storybooks%2Fstorybook-addon-knobs
MIT License
76 stars 26 forks source link

Update react to 17? #50

Closed eivindml closed 2 years ago

eivindml commented 3 years ago

Hi,

the map gives a error now. I think it's an issue with colliding react versions. Could it be updated to react 17?

Skjermbilde 2021-01-12 kl 11 15 16
chrisdrackett commented 3 years ago

Thanks for the note! I'd welcome a PR for this otherwise I'll try and get to it Monday!

eivindml commented 3 years ago

Thanks! :) Just to clarify: I figured out that the problem above was that another workspace in my monorepo used another version of react, so I solved this issue by upgrading that. But as far as I know, React 17 will make issues like this less likely to happen, so it's a good upgrade any way. :)

chrisdrackett commented 2 years ago

sure, but because this is an add-on package it should just work with whatever version of react you have as long as its greater than 16.8.x. The package does not install react itself.