search

chrisedg87 / flutter_rounded_loading_button

A simple implementation of an animated loading button widget for Flutter
MIT License
339 stars 87 forks source link

Null safety #28

Closed jonbhanson closed 3 years ago

jonbhanson commented 3 years ago

Thanks for this package! Do you plan to add null safety?

joaovvrodrigues commented 3 years ago

Hello, I created a PR where I applied nullsafety, updated the dependencies and removed the RaisedButton, if you want to test or use it while they don't update, just add it to your pubspec.

rounded_loading_button: git: url: https://github.com/joaovvrodrigues/flutter_rounded_loading_button

Captura de Tela 2021-03-08 às 13 22 13

Macacoazul01 commented 3 years ago

any updates on this?

mi1971 commented 3 years ago

@joaovvrodrigues Hey thanks for this null safe version. Just a question...I directly substituted your button for the original one, and although my loading spinner shows...it now fails to animate the size of the button (ie shrinking down to a circle, and back to a button). It now spins, and then jumps to the small round size, and then jumps back to button size with no smooth animation. It could be something I've done, but could you confirm the animation is working for you like it does in the animated gif example? Thanks!!

AniButtonIssue

joaovvrodrigues commented 3 years ago

@mi1971 Helo! Thanks for the comment, there really was this problem, it was something I missed when converting to an elevated button, but I believe I managed to fix it now. Please update and confirm for me that everything is ok!

mi1971 commented 3 years ago

Hi @joaovvrodrigues You got it! Thank you so much! It all seems to be working now.

chrisedg87 commented 3 years ago

Merged PR #32 which addresses the null safety so closing this one.