chriseidhof / pomotv

http://www.pomo.tv
183 stars 29 forks source link

Video ID generation struggles with some characters #112

Open douglashill opened 8 years ago

douglashill commented 8 years ago

Problem encountered at https://github.com/chriseidhof/pomotv/pull/108#discussion-diff-61190690 which can cause the build to fail when video titles have certain combinations of characters. See discussion there for background.

I’m no expert here, but I think the problem is the the output from the safe_parameterize method, which comes from middleman. The documentation says this method is to “Parameterize a string preserving any multibyte characters”. Preserving multibyte characters does not sound like a good thing for generating strings for paths in URLs.