search

chriseidhof / pomotv

http://www.pomo.tv
182 stars 29 forks source link

Added iOS Conf Singapore #52

Closed BalestraPatrick closed 8 years ago

BalestraPatrick commented 8 years ago

Added iOS Conf Singapore (from #49).

I also noticed that some tags are capitalized but most of them are lowercase. I changed the capitalized ones to lowercase to be consistent with the rest of the page.

If anyone could quickly give it a second look and then merge, that would be perfect!

chriseidhof commented 8 years ago

The URL should include the http://www part :)

BalestraPatrick commented 8 years ago

Oops, I knew I was missing something! Fixed now. 😃

johankj commented 8 years ago

Perhaps squash the commits into one before merging?

chriseidhof commented 8 years ago

That'd be nice indeed. Let's try to do it in the future =)

johankj commented 8 years ago

@chriseidhof: Just FYI, it could still have been done before you merged it. As seen in this guide you can squash/rebase it locally and just do a force push. The pull request is connected to a specific branch – usually not the master-branch but it works just as well – and any changes to the branch will be shown in the pull request, even if you force push changes to the git history.

This is also the way pull requests are handled in the Swift repositories: example.