search

chriseidhof / pomotv

http://www.pomo.tv
183 stars 29 forks source link

Easier import for WWDC #61

Closed JaviLorbada closed 8 years ago

JaviLorbada commented 8 years ago

This needs approval since do not have speakers for the talks.

chriseidhof commented 8 years ago

Oh, cool! I think it'd still be really helpful to add the speakers. The information is in the talks, I guess. Maybe we can split up the work among a few people? For example, everyone takes a year?

JaviLorbada commented 8 years ago

Agreed, let's do this all together 💪

Speakers info is usually in the transcript, i.e: http://asciiwwdc.com/2014/sessions/301, but sometimes is kinda difficult to find them.

chriseidhof commented 8 years ago

So maybe it's easiest to do this in multiple PRs? That way, whoever has time can pick up a single one? I'm sorry for the extra trouble, but I think the community will really benefit from this!

JaviLorbada commented 8 years ago

Do you prefer to merge this and complete the speakers later with smaller PRs?

Or create new PRs for each year with all the info, event, videos, speakers?

chriseidhof commented 8 years ago

My thinking was to create a WIP PR for each year. Then we can assign those and someone can add the speakers for that year. Does that make sense? Or is it too much effort?

JaviLorbada commented 8 years ago

@chriseidhof could we merge 47ed7e5 and e901a24?

Then it's easier to create the other PRs. Thanks! :bow:

chriseidhof commented 8 years ago

I merged e901a2457fb103c930fe77514d2d619c56050616, but not the other commit. I think if we add speakers for each video, we won't need it. This way we get an error when there are no speakers, rather than silently fail!

JaviLorbada commented 8 years ago

Cool! Totally understand. I will create the other PRs in the meantime.

Shall we include also description information as in: https://github.com/chriseidhof/pomotv/commit/47ed7e54c61eb51b49e4cad51c5cc78615716564#diff-15105b1313061cab6e4e2d5b20e132f5R14

I dunno if we want to have that description only for WWDC or for the rest as well.

pomotvbot commented 8 years ago

Adding the description is a great idea!

Sent from my iPhone

On 22 Dec 2015, at 11:36, Javi Lorbada notifications@github.com wrote:

Cool! Totally understand. I will create the other PRs in the meantime.

Shall we include also description information as in: 47ed7e5#diff-15105b1313061cab6e4e2d5b20e132f5R14

I dunno if we want to have that description only for WWDC or for the rest as well.

— Reply to this email directly or view it on GitHub.