chriseldredge / Klondike

Ember front-end that builds on NuGet.Lucene for private package hosting
Apache License 2.0
299 stars 74 forks source link

Nuget.exe push behaving differently pushing to Klondike v2.1.1 after upgrade from v.1.6.2 #191

Open RyPhi76 opened 7 years ago

RyPhi76 commented 7 years ago

I have a database build that yields four .nupkg packages.

Three of them get pushed to our new v.2.1.1 Klondike server with no issues but one package, named Database.Patch.version.nupkg, keeps getting converted to a *.symbols.nupkg package and pushed to the symbols folder.

The same Nuget push command pointing to our old v.1.6.2 Klondike server behaves correctly placing the package in the packages folder.

I am able to manually execute the Nuget Push from the command line from our [TeamCity] Build Agent server and continually encounter the same issue.

I have tried using Nuget version 3.1, 3.5, and 4.1.

I have also specified the -NoSymbols argument all to no avail.

I presume there is something in the contents of the package that is triggering this to occur but I can't seem to identify it. I had thought it was the presence of .pdb files but I have .pdb files in other packages that are pushing just fine.

We don't use symbols at all whatsoever.

Any assistance troubleshooting this would be great.

Thank you, Ryan P

lukeskinner commented 7 years ago

https://github.com/themotleyfool/NuGet.Lucene/blob/bfb950418a939fab5183dcc0c0136a2e1e7e3df5/source/NuGet.Lucene/Util/PackageExtensions.cs

        public static bool HasSourceAndSymbols(this IPackage package)
        {
            var hasSymbols = package.GetFiles()
                .Any(pf => string.Equals(Path.GetExtension(pf.Path), ".pdb",
                    StringComparison.InvariantCultureIgnoreCase));

            return hasSymbols && package.GetFiles("src").Any();
        }

My first guess would be this method that's causing the problem. It's called when you upload a package - if it returns true it will redirect the upload to the symbols service.

Check if you have a 'src' folder at the root of your NuGet package.

chriseldredge commented 7 years ago

Here's some background on this problem: http://chris.eldredge.io/blog/2015/01/05/nuget-symbols-and-aspnet-vnext/.

I'm not working on Klondike actively, but still willing to maintain the project and merge PRs.

RyPhi76 commented 7 years ago

Yes! Yes we do. What are the next steps from this point??

Ryan Philippi Release Engineer DealerSocket, Inc.


P:949-900-0300 x615 F:949-940-1075 W:www.dealersocket.com


Support: 888-988-6444 WE ARE AUTOMOTIVE

Facebookhttp://www.facebook.com/DealerSocket :: Twitterhttps://twitter.com/dealersocket :: Instagramhttp://instagram.com/dealersocket/

From: Luke Skinner [mailto:notifications@github.com] Sent: Thursday, June 1, 2017 4:56 AM To: themotleyfool/Klondike Klondike@noreply.github.com Cc: Ryan Philippi RPhilippi@dealersocket.com; Author author@noreply.github.com Subject: Re: [themotleyfool/Klondike] Nuget.exe push behaving differently pushing to Klondike v2.1.1 after upgrade from v.1.6.2 (#191)

https://github.com/themotleyfool/NuGet.Lucene/blob/bfb950418a939fab5183dcc0c0136a2e1e7e3df5/source/NuGet.Lucene/Util/PackageExtensions.cs

    public static bool HasSourceAndSymbols(this IPackage package)

    {

        var hasSymbols = package.GetFiles()

            .Any(pf => string.Equals(Path.GetExtension(pf.Path), ".pdb",

                StringComparison.InvariantCultureIgnoreCase));

        return hasSymbols && package.GetFiles("src").Any();

    }

My first guess would be this method that's causing the problem. It's called when you upload a package - if it returns true it will redirect the upload to the symbols service.

Check if you have a 'src' folder at the root of your NuGet package.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/themotleyfool/Klondike/issues/191#issuecomment-305471862, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AbkhTaXKiKKCkNJSQ84XJGsSgqsECea6ks5r_qbagaJpZM4NsI-P.

RyPhi76 commented 7 years ago

Thanks @chriseldredge and @lukeskinner! I omitted the /src folder within the .nuspec and this issue is resolved.