search

chriseldredge / Lucene.Net.Linq

LINQ provider to run native queries on a Lucene.Net index
Other
151 stars 66 forks source link

Made method virtual allowing custom IDocumentKey creation #99

Closed mcintyre321 closed 8 years ago

mcintyre321 commented 8 years ago

I made a property on DocumentMapperBase virtual so that I can implement my own IDocumentKey type for custom object loading.

mcintyre321 commented 8 years ago

Any chance of having this merged and pushed up? As far as I can tell this is just correcting a mistake (that the properties on this class which create IDocumentKeys should be virtual so that custom implementation can be used).

chriseldredge commented 8 years ago

This looks like a step in the right direction, but subclasses that want to override ToKey may want to make use of ValidateKey which is currently private. What do you think about changing ValidateKey to protected virtual as well?

mcintyre321 commented 8 years ago

I did that initially then undid it in case it made the PR less likely to get accepted!

I can add it back in if you like. :) On 16 Jun 2016 19:24, "Chris Eldredge" notifications@github.com wrote:

This looks like a step in the right direction, but subclasses that want to override ToKey may want to make use of ValidateKey which is currently private. What do you think about changing ValidateKey to protected virtual as well?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/themotleyfool/Lucene.Net.Linq/pull/99#issuecomment-226571023, or mute the thread https://github.com/notifications/unsubscribe/AAQ0-tIfCD0OCv9WH0mpIjT-uMsk2xtGks5qMZT3gaJpZM4IxSYr .

mcintyre321 commented 8 years ago

Done!

mcintyre321 commented 8 years ago

Could you push a new Nuget package please? thanks again

chriseldredge commented 8 years ago

3.6.0 was just pushed to nuget.org with this change.