chrisfarber / ember-breadcrumbs

An Ember.js component for adding breadcrumbs to your app.
MIT License
79 stars 34 forks source link

Cease proxying warning. Fixes #22 #26

Closed pgasiorowski closed 9 years ago

pgasiorowski commented 9 years ago

Fix #22

pgasiorowski commented 9 years ago

Good spot @msalahz. I updated the pr

msalahz commented 9 years ago

Thank you @WooDzu

chrisfarber commented 9 years ago

Cool, this is a good idea. Based on some experimenting, it looks like it works correctly for computed properties/etc. There are still cases where it can display the deprecation warning (e.g., if breadCrumb is not defined but breadCrumbs is), but I can take care of that. I'll get this merged in sometime this week.

msalahz commented 9 years ago

Great, Thanks @chrisfarber

pmdarrow commented 9 years ago

Anything I can do to help move this along? @chrisfarber

chrisfarber commented 9 years ago

I've reverted this for 0.1.6. See Issue #27.