chrisfisher / react-native-directed-scrollview

UNMAINTAINED- see below. A natively implemented scrollview component which lets you specify different scroll directions for child content.
MIT License
149 stars 67 forks source link

Getting com.facebook.react.bridge.NativeArgumentsParseException #31

Closed kkarmalkar closed 6 years ago

kkarmalkar commented 6 years ago

I have used scrollview given in sample app and when I run it on android it throwing below error:

com.facebook.react.bridge.NativeArgumentsParseException: TypeError: expected dynamic typedouble', but had type null' (constructing arguments for UIManager.dispatchViewManagerCommand at argument index 1)

"react": "^16.2.0", "react-native": "^0.49.5", "react-native-directed-scrollview": "^1.3.6",

Can anyone help me out.. please.!!

lecler-i commented 6 years ago

This is related to commit 767081ef8c242e30b08abe703d98deafc9e548f1

https://github.com/chrisfisher/react-native-directed-scrollview/commit/767081ef8c242e30b08abe703d98deafc9e548f1#diff-168726dbe96b3ce427e7fedce31bb0bc

That fix a bug on iOS for a regression on Android. I'll try to send a PR tomorrow to fix the issue

kkarmalkar commented 6 years ago

Thanks @lecler-i ... let me know once issue is fixed and in which version it is fixed?

kkarmalkar commented 6 years ago

Hi @lecler-i, it will really helpful if this issue gets fixed as earliest, one of our app is going live on production and before that we want to fix issue observed. We appreciate your help.. Thanks..!!

SatVel commented 6 years ago

@lecler-i - I am also facing this issue. It would be great if you could give a bug-fix ASAP. Thanking you in advance!

ChengHsuanLiu commented 6 years ago

@kkarmalkar This issue happened to me too. My app works well on iOS but when I run on Android, it shows type error as below:

29132993_10204634004805715_5150280560932814848_o

My versions:

"react": "^16.2.0", "react-native": "^0.53.3", "react-native-directed-scrollview": "^1.3.6"

Any solutions here?

kkarmalkar commented 6 years ago

@ChengHsuanLiu Same red screen I am also getting with same error message. I am still waiting for solution from @lecler-i , he is going to fix it

lecler-i commented 6 years ago

Hello,

Sorry i won't have the time right now, busy week...

Don't count on me for this, i will but when i find time to

Best is to revert on previous version that should be usable and without the issue

https://github.com/chrisfisher/react-native-directed-scrollview/index.js#L43

Try do this only on iOS, will prevent the crash on android (if (Platform.OS === 'ios')) Should do the job i think

On 03/12/2018 11:32 PM, kkarmalkar wrote:

@ChengHsuanLiu https://github.com/chenghsuanliu I am still waiting for solution from @lecler-i https://github.com/lecler-i , he is going to fix it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chrisfisher/react-native-directed-scrollview/issues/31#issuecomment-372373986, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKDU0lQmF8Z1LNUq5lsHSReX4LImkRfks5tdqMTgaJpZM4SjAdY.

lecler-i commented 6 years ago

Clean fix by @kevinsperrine

https://github.com/kevinsperrine/react-native-directed-scrollview/commit/87c2583dd13f94427672b3a82dac5d761e025169

chrisfisher commented 6 years ago

Try 1.3.7 for @kevinsperrine's fix.