chrisfisher / react-native-directed-scrollview

UNMAINTAINED- see below. A natively implemented scrollview component which lets you specify different scroll directions for child content.
MIT License
149 stars 67 forks source link

Fix android alwaysBounce behavior #36

Closed lecler-i closed 6 years ago

lecler-i commented 6 years ago

From PR #24

I implemented alwaysBounceVertical / alwaysBounceHorizontal incorrectly on android. My first imple : Disable bounce if those props are set to false.

Correct imple according to the doc (https://facebook.github.io/react-native/docs/scrollview.html#alwaysbouncevertical) :

When true, the scroll view bounces vertically when it reaches the end even if the content is smaller than the scroll view itself. The default value is false when horizontal={true} and true otherwise.

Now, the above props will enable bouncing even if the content is smaller than the container if set to true (default to false)