D2 heatmap breaks when match history was previously private

chrisfried / secret-scrublandeux

A calendar heatmap of time spent playing Destiny 2

https://chrisfried.github.io/secret-scrublandeux/

MIT License

59 stars 9 forks source link

D2 heatmap breaks when match history was previously private #7

Open CodyFitzpatrick opened 5 years ago

CodyFitzpatrick commented 5 years ago

I change my game history back and forth between private and public from time to time, and noticed the below when I went to check my heatmap today (yes, I am fortunate enough to be able to play a lot):

Broken Heatmap for D2 - Network Error Broken Heatmap for D2 - Console Error

CodyFitzpatrick commented 5 years ago

The easy solution is to skip over data returned from the bungie API if it is error code 1665 or if there is no object returned and that object is not a string. Could be done via a simple "if" clause while populating the heatmap unless I'm missing something big.

CodyFitzpatrick commented 5 years ago

P.S. I'm not sure if the application is trying to store all history within a single variable, but for a guardian nearing 2000 hrs of playtime, I can't imagine it'd fare well!