search

chrisgillis / slackwolf

A slack bot that moderates Werewolf games
343 stars 68 forks source link

Adding option for vanilla role strategy #53

Closed codejr closed 7 years ago

codejr commented 7 years ago

Working implementation for #3 and #4.

I don't write PHP so I may have gotten some things wrong in terms of best practices. Constructive criticism on that is appreciated.

Also, some discussion on the specifics for these issues should be had as well. Such as maybe adding the ability to have the role strategy set per game and whether or not there should be a seer.

chrisgillis commented 7 years ago

Left a few comments. Let me know when you'd like me to merge, looks good to me :)

I'm excited to see another contributor. Thanks!

codejr commented 7 years ago

Actually, I just noticed this does not work if using !new. I think i'm going to change the game creation logic a bit and update it before we merge.

chrisgillis commented 7 years ago

Okay. For reference, our company almost always uses lobbying ( !new / !join / !start ) to start its games.