Open JorgeR81 opened 2 days ago
The Trung0246
switch, has another fundamental advantage over the other switches I tested.
This switch can really simulate a wire being unplugged in the workflow, in a way other switches can't.
Example:
Here, I'm switching between KSampler
and SamplerCustomAdvanced
, to get a single final image.
With the Trung0246
switch, the Sampler I select it's the only one that generates an image.
The same would happen, if I just plug the wire directly, from one of the samplers to the VAE Decode
.
But if I use another switch ( e.g. Impact Pack
, WAS node suite
), both samplers would run, one after the other.
Technically these switches "work", because the final image corresponds to the sampler I selected.
And after generating, if I switch samplers, the other image is shown, without needing to run the other Sampler again.
This is a good thing, because we can get the 2 images, without wasting more resources
But I wanted to run 2 samplers, to get 2 images, I wouldn't need a switch !
If you plan to add support for more custom nodes, ( beyond the rgthree lora loader ), this could be the next one. https://github.com/Trung0246/ComfyUI-0246
If we have good switches in the Controller, it would be less necessary to make constant changes in the workflow.
The
Impact Pack
switch is working now on the Controller. It allows different types of inputs. And it also allows any number of inputs. But it has limitations, when we use it in the Controller. The input selection is numeric, so we can't be sure about the input we are selecting, unless we see the nodes in the graph.With the
Trung0246
switch, we can rename a slot, and it will show up in the selector widget, in a dropdown list !And as a bonus, the Trung switch allows multiple outputs. Each output has its own switch. So we could add multiple switches to the Controller with a single node, and also the workflow would be less cluttered.