search

chrisgoringe / cg-controller

MIT License
30 stars 3 forks source link

Improving performance when we bypass individual nodes #324

Closed JorgeR81 closed 1 day ago

JorgeR81 commented 2 days ago

When we click the header button to bypass/mute individual nodes, it takes about a 1 or 2 seconds to update.

But when we toggle whole groups it is much faster.

Is it possible to improve the individual toggle speed ?

Having the lag, may confuse new users. So they will click twice, and nothing will happen ( because they will just revert the "first click", before the update happens ).

by

chrisgoringe commented 2 days ago

I don't experience this... could you see what comes up in the JavaScript console when you click the node bypass?

JorgeR81 commented 2 days ago

Each time I click I have this:

b1

LukeG89 commented 2 days ago

Each time I click I have this:

I also get these, but I don't experience any delay

JorgeR81 commented 2 days ago

I've made some more tests on Chrome.

Immediately after refreshing the browser, performance is good, but then it gets worse with time. The same thing happened with the other performance issues ( https://github.com/chrisgoringe/cg-controller/issues/315 )

chrisgoringe commented 2 days ago

Those messages are good.

It sounds like a resource leak. I'll investigate