chrisgoringe / cg-controller

MIT License
31 stars 3 forks source link

[Bug] Updating doesn't work with subgroups #349

Open LukeG89 opened 4 hours ago

LukeG89 commented 4 hours ago

I tested how Controller updates when there are subgroups.

Controller doesn't update when:

https://github.com/user-attachments/assets/c5f9fcf4-bdb7-4117-a8e0-108c0d2ff4d5

https://github.com/user-attachments/assets/f4bb8c23-d9cf-4965-ae84-97296021014e

chrisgoringe commented 3 hours ago

I haven’t even looked at how subgroups work 😀

On Sat, 16 Nov 2024 at 8:18 PM, LukeG89 @.***> wrote:

I tested how Controller updates when there are subgroups.

Controller doesn't update when:

  • Moving in or out a subgroup from a group
    • Even refreshing node def doesn't update it (it will update when you make a change)

https://github.com/user-attachments/assets/c5f9fcf4-bdb7-4117-a8e0-108c0d2ff4d5

  • Moving a node from a group to its subgroups
    • You need to move the node from canvas or an external group to access a subgroup

https://github.com/user-attachments/assets/f4bb8c23-d9cf-4965-ae84-97296021014e

— Reply to this email directly, view it on GitHub https://github.com/chrisgoringe/cg-controller/issues/349, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBLMA7MPNJ7ALVQKMMQOUT2A4EU5AVCNFSM6AAAAABR4UHYHCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3DIMBWGQZDSMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LukeG89 commented 3 hours ago

I haven’t even looked at how subgroups work 😀

It's the first time I've looked at it too! 😆 I encountered some update problems while testing this #347, so I further investigated 🔍

JorgeR81 commented 2 hours ago

Yeah, "group nesting" ( in Frontend v1.3.32 ) is also causing this issue: https://github.com/chrisgoringe/cg-controller/issues/347#issuecomment-2480505295