[ feature ] Display free node inputs

[JorgeR81]

We could have an user option to display free inputs in the Controller, in each node's header.

Some free inputs may result in an error.

This will allow to check for free inputs in the Controller.

It could be even easier than to do it in the graph !

---

[LukeG89]

How about optional inputs?

[JorgeR81]

How about optional inputs?

These inputs could also be displayed with a hole inside the dot, to differentiate from the other ones.

[chrisgoringe]

This seems fairly non-core?

On Sat, 16 Nov 2024 at 9:07 PM, JorgeR81 @.***> wrote:

How about optional inputs?

These inputs could also be displayed with a hole inside the dot, to differentiate from the other ones.

— Reply to this email directly, view it on GitHub https://github.com/chrisgoringe/cg-controller/issues/350#issuecomment-2480501900, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBLMA4TCJTWMMXQY2RUWED2A4KN3AVCNFSM6AAAAABR4UW6UKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGUYDCOJQGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[JorgeR81]

This seems fairly non-core?

The optional inputs ( with a hole inside the dot ) are ComfyUI core.

Try adding a new Apply ControNet node ( the old one still exist, but it's deprecated ),

It has an optional VAE input ( required for SD3 and Flux ).

[chrisgoringe]

sorry, I meant not really core to the Controller....

On Sat, 16 Nov 2024 at 22:36, JorgeR81 @.***> wrote:

This seems fairly non-core?

The optional inputs ( with a hole inside the dot ) are ComfyUI core.

Try adding a new Apply ControNet node ( the old one still exist, but it's deprecated ),

It has an optional VAE input ( required for SD3 and Flux ).

cn.png (view on web) https://github.com/user-attachments/assets/259ef736-3a8a-4d54-994a-4fbfd48e1409

— Reply to this email directly, view it on GitHub https://github.com/chrisgoringe/cg-controller/issues/350#issuecomment-2480531528, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBLMA4YKFQY26IE3YCNEE32A4U3FAVCNFSM6AAAAABR4UW6UKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGUZTCNJSHA . You are receiving this because you commented.Message ID: @.***>

[JorgeR81]

Yes, I agree this is a non essential feature.

But I think it's still related to the Controller, because it also gives information about the node status.

Not only about widget values or bypass/mute state, but also about the connection status. This is really the only type of information we still miss in the Controller.

If it's not very complex to add, it may be worth having it.

[JorgeR81]

I'm not sure you can see the mockup image via phone / e-mail.

I think it looks clean. It does not clutter the GUI.

[LukeG89]

I think it looks clean. It does not clutter the GUI.

That's depends. How would look a node with a long name + many non-connected inputs?

[JorgeR81]

That's depends. How would look a node with a long name + many non-connected inputs?

Yes well, I guess the name would be partially covered. 

But this feature does not need to be always "on".

It may work better like the node "node highlight" feature. Like an "utility" that we just want to turn on sometimes, to check the graph status, once it's built.

It could also have a GUI button.

If enabled in the user settings, we would have a new Topbar button.

Maybe this one ?

[chrisgoringe]

One complication would be working with use everywhere nodes or similar, that connect inputs that aren't really connected.

If only we had access to the developer of those nodes...

[LukeG89]

It could also have a GUI button.

If enabled in the user settings, we would have a new Topbar button.

No please! Not another button on topbar!! 😭

[JorgeR81]

No please! Not another button on topbar!! 😭

It would only be visible when the Controller is enabled. And we could have an "user setting" to disable it.

We need to strike a balance. Some users don't even use worflow tabs. And I still have free space to open 7 workflow tabs in a single row.

[LukeG89]

We need to strike a balance. Some users don't even use worflow tabs. And I still have free space to open 7 workflow tabs in a single row.

Yeah, but you need to consider smaller monitors and buttons from other extensions.

In my opinion, this is just a waste of topbar space for this kind of features (even highlight mode tbh)

And we could have an "user setting" to disable it.

But that's ok if we can turn it off.

[LukeG89]

An alternative could be using a dropdown list like it was the save button in 1.2 frontend. This way you can add all the buttons you want

[JorgeR81]

Yeah, but you need to consider smaller monitors and buttons from other extensions.

My monitor it's only 1920 x 1080, so it's also not on the larger side.

The Topbar is designed to work with multiple rows, exactly for these reasons.

Removing 4 or 5 icon buttons will only give you an extra workflow tab.

---

An alternative could be using a dropdown list like it was the save button in 1.2 frontend.

If this is possible, I don't mind having that.