chrisgoringe / cg-controller

MIT License
30 stars 3 forks source link

Issue with sliders #40

Closed chrisgoringe closed 1 month ago

chrisgoringe commented 1 month ago

See https://github.com/chrisgoringe/cg-controller/issues/30#issuecomment-2395198657

chrisgoringe commented 1 month ago

373907929-5860a0bd-d032-4116-b1b5-1dbabafe1e59

copy of image from original report

chrisgoringe commented 1 month ago

I can't reproduce this. Could you check the javscript console, or share a workflow in which you see it? @JorgeR81

JorgeR81 commented 1 month ago

I tried again with the default workflow.

This time I tried a Primitive and the value rounding worked.

The rounding issue was with custom float nodes. I tried:

But the min / max values still don't work, even with a Primitive.

test

chrisgoringe commented 1 month ago

A workflow where it isn't working would be a big help :)

JorgeR81 commented 1 month ago

OK, this one uses a single Primitive ( no custom nodes ). The rounding works, but not the min / max values.

controller_test_1.json

JorgeR81 commented 1 month ago

This one uses the node from Impact-Pack.

So it also has the rounding issue.

controller_test_2.json

c2

JorgeR81 commented 1 month ago

The value rounding also works well with the KSampler widgets. But the min / max values, in the controller settings, don't seem to work either

Another problem is the seed slider. Maybe for this widget we could have a full width input box and a slider below ( it would use 2 lines, if possible ).

ks1

JorgeR81 commented 1 month ago

If you could use this style of slider it would allow larger values ( e.g. seed ) and it probably look better.

https://github.com/florestefano1975/comfyui-portrait-master

slider style

JorgeR81 commented 1 month ago

The Blender sliders look amazing ! I love the way they integrate slider and input box. This GUI is very clean and easy too read.

https://forum.qt.io/topic/145406/best-practices-factoring-code-to-create-a-custom-slider

EQxb4