chrisgoringe / cg-controller

MIT License
26 stars 3 forks source link

Step not saved (clash with precision?) (was: Add step editing (was: Slider min/max/step editing)) #61

Open chrisgoringe opened 1 week ago

chrisgoringe commented 1 week ago

This is step 2 from https://github.com/chrisgoringe/cg-controller/discussions/59#discussioncomment-10875040

Add the ability to edit the start/stop/round attributes of a slider (triple-click or shift-click, probably, popping up a dialog). This will be saved to a shared table, with options:

At this point the old mechanism will be retired (maybe auto converted, maybe not!)

JorgeR81 commented 1 week ago
  • apply to all [cfg] sliders on any node

Can you detect if a FLOAT or Primitive node is connected to a "cfg" input ? And also apply the same settings to all these sliders.

If so, Step 3 ( the global slider table ) may not be necessary.

cfg

JorgeR81 commented 2 days ago

The slider edit table ( https://github.com/chrisgoringe/cg-controller/issues/62 ) may not be needed, if ComfyUI gets sliders in the future, ( and they add a "native" edit table ).

I have an open feature request for sliders in ComfyUI ( https://github.com/Comfy-Org/litegraph.js/issues/193 ) But I have no idea if/when they will add sliders, or if all widgets will have sliders ( or if they plan an edit table ).

I think it's the lack of a slider editing system, that keeps sliders from being added to ComfyUI.

Because, apparently, you can already add a slider to a specific widget, if you change the code, and add the slider parameters: https://github.com/Comfy-Org/litegraph.js/issues/193#issuecomment-2424875055 ( but your changes will be lost, the next time you update ComfyUI ).

And also, I think other custom extensions have been using these "hidden" native Comfy UI sliders, for a while now. But for these use cases, the slider parameters are probably hard coded. ( https://github.com/florestefano1975/comfyui-portrait-master )

LukeG89 commented 1 day ago

@chrisgoringe In the documentation I suggest adding that the range you set on the controller slider will also be applied on the node widget.

JorgeR81 commented 8 hours ago

I have the new edit GUI. But the new step size is not applied to the slider.

The step size is not saved. When open the edit GUI again, it shows the old step value.

stp


I think it worked the first time I tried. But now it does not work. Even when I restart ComfyUI.

LukeG89 commented 8 hours ago

I can confirm, it doesn't keep the new step size

LukeG89 commented 7 hours ago

I found another issue. When you set a min/max range, it becomes difficult to change values on the widget using the arrows; many clicks to just change of 1 step

https://github.com/user-attachments/assets/0bf4a042-6ac5-462d-a18a-ed31c424d925

chrisgoringe commented 7 hours ago

Probably related.

Weird.