search

chrisgoringe / cg-image-picker

227 stars 15 forks source link

Error After Update #34

Closed trashie65 closed 11 months ago

trashie65 commented 11 months ago

Hi After updating today i now get this error

image error

Also from the comfy log:

File "D:\ComfyUI_windows_portable_nvidia_cu118_or_cpu\ComfyUI_windows_portable\ComfyUI\custom_nodes\cg-image-picker\image_chooser.py", line 87, in func i = (int(MessageHolder.waitForMessage(id))-1) % images.shape[0] ValueError: invalid literal for int() with base 10: 'Always pause'

I too have the issue that i have no right click option and also the floating cancel box is not showing?

chrisgoringe commented 11 months ago

Can you try deleting the chooser node and creating a new one? And if it's still a problem, could you post a screenshot of the relevant nodes in your workflow?

trashie65 commented 11 months ago

Ive already deleted and added another one.. you want a screen shot of all the nodes?

chrisgoringe commented 11 months ago

Mostly just the chooser node - the problem here is that it is sending the value of the mode widget ('Always pause') when it should be sending the choice...

chrisgoringe commented 11 months ago

Also, pls check if there are any relevant looking things in the javascript console

trashie65 commented 11 months ago

image error2

Where is the javascript console?

trashie65 commented 11 months ago

if its F12 then im looking now

can't see anything

chrisgoringe commented 11 months ago

Attached here is a very simple workflow that is currently working on my install. Could you see if it works on yours? That will really help to narrow this bug down!

workflow.zip

trashie65 commented 11 months ago

image error3

trashie65 commented 11 months ago

The weird thing is apart from the floating canel box and the right clicking to choose the image, the rest was working befor the update?

trashie65 commented 11 months ago

Do we have any update on the bug finding? at the moment i am using a previous version which is working ok... except for the floating cancel and the right click option?

chrisgoringe commented 11 months ago

Take a look at the new branch mentioned towards the end of this thread

https://github.com/chrisgoringe/cg-image-picker/issues/33

I'm probably not going to fix issues in the old nodes, the new one is so much cleaner and more reliable