chrisgoringe / cg-image-picker

227 stars 15 forks source link

(Ctrl - )click to select or unselect #36

Closed chrisgoringe closed 10 months ago

Erehr commented 11 months ago

I just noticed that left click on image no longer change it to single view like normal/previous preview node and I actually like it and think it should remain that way. So maybe the select/unselect could be done with just left click instead of with ctrl?

One annoying thing now is that the image with mouse hovering on it get brighter. I can understand the reason on normal preview node but here I'm trying to decide which image to choose and have to constantly avoid it with mouse to get accurate colors. So maybe that could be removed or replaced with a simple border around.

chrisgoringe commented 11 months ago

Will look at that. The reason I've currently done it as I have is that adding to the right-click menu is directly supported in ComfyUI, so I think it's a lot less likely to get broken. Similarly the brightness is done deep in the ComfyUI code....

So I only plan to change those things if I can find a safe place to hijack the code!

Erehr commented 10 months ago

Love it. :heart: Except now there's no way to cancel waiting chooser I think. There's no cancel button on hud and chooser (blank button without text) and no cancel under right click menu.

Erehr commented 10 months ago

Also probably a bug: Can't cancel there either if the chooser is waiting image

chrisgoringe commented 10 months ago

right-click on the background canvas?

chrisgoringe commented 10 months ago

Also probably a bug: Can't cancel there either if the chooser is waiting image

Added #40

chrisgoringe commented 10 months ago

Love it. ❤️ Except now there's no way to cancel waiting chooser I think. There's no cancel button on hud and chooser (blank button without text) and no cancel under right click menu.

added as #41

chrisgoringe commented 10 months ago

Fixed - there is now a cancel button on the chooser, and cancel works from the "Running" section