chrisgoringe / cg-image-picker

227 stars 15 forks source link

Added three new modes: pass through, pick first n, pick last n #59

Closed ech3lon24 closed 9 months ago

ech3lon24 commented 9 months ago

I added three new modes to the very awesome preview-chooser node. I made these because they were useful for my workflows.

Pass through:

Pick first n:

Pick last n:

ech3lon24 commented 9 months ago

Nice clean change.

Just one request: in L64 could you express the condition in a way that avoids the if (A or B and C) form, so anyone who reads the code doesn't need to think about precedence rules for logical operators...

Even if it's just by using brackets - if ( (A or B) and C ) - I think it improves code maintainability...

Agreed. It should be more readable now.

chrisgoringe commented 9 months ago

thanks. nice addition.