chrisgoringe / cg-image-picker

227 stars 15 forks source link

[Feature Request] Discard mode #60

Closed noembryo closed 7 months ago

noembryo commented 9 months ago

Seeing the #59 I thought of something that it will greatly help my daily routine. An extra mode. A Discard all (but not pass through) mode.

I don't know if it's already possible with some other configuration, but this is what I do: I don't work with batches of many images. I have the preview chooser node before the last Save Image node of my workflow. Most of the time I try things that I don't want saved, so I always press the "Cancel current run" after I see the output that I'm not satisfied with. I only want to save the ones I like, so I press the "Progress selected Image" for them. That's why it will be really helpful if I could have every generation cancelled until I find one that I like to select and press the "Progress selected Image" for it.

BTW nice node. 👍 Thank you for your work.. 😃

chrisgoringe commented 9 months ago

I don't quite understand how this would work. Maybe I haven't understood?

If you set it to discard all, how will you get the images that you do like? Surely you need to decide once you see the image, and either pass it on or not (which you can do with "Cancel Current Run" as you do at the moment)? Note that you can't change the mode once the workflow has started...

When I'm doing what you describe I turn Auto Queue on, then when I cancel it restarts automatically.

noembryo commented 9 months ago

Perhaps my explanation wasn't that good.. What I'm trying to avoid is the pressing of the Cancel button (that's happening a lot!!). What I would like, is something that I don't think is possible at the moment.

When the image arrives at the node, it should display itself and always choose the Cancel action. If I don't like it (like most of the times) I can start a new generation. But if I like what I see, I want to have the option to select the image and press Progress selected image so that it can be saved.

chrisgoringe commented 9 months ago

So does it give you a period of time to decide you do like the image before it does a cancel and restart? Or are you thinking that you would be able to think about it while the next image is being generated?

noembryo commented 9 months ago

Actually I was thinking of always Canceling. The next generation should be manual. Nothing to do with the saving of the image.

noembryo commented 9 months ago

Start a generation. I don't like the outcome. Start another. I like this one. Select the image>Press Progress selected. Start another. Start another. I like this one. Select the image>Press Progress selected. Start another. .... No Cancel pressing for me..

chrisgoringe commented 9 months ago

But instead you keep pressing "start"? If you turn on auto queue, cancel effectively does start as well... so one press either way?

noembryo commented 9 months ago

Well, yeah, but there is not a keyboard shortcut for Cancel, contrary to the Ctrl+Enter..

chrisgoringe commented 9 months ago

I'm imagining another node - one that shows you a single image and you click "yes" or "no". Yes passes it on, No cancels the run and starts another...

noembryo commented 9 months ago

If I want to change something in another node, the mouse is away from the preview and I have to go back there and target the cancel button... This is what I try to avoid.

I'm imagining another node - one that shows you a single image and you click "yes" or "no". Yes passes it on, No cancels the run and starts another...

Hopefully with a keyboard shortcut? 😉

revolvedai commented 8 months ago

Removing the cancel would be great. You would just queue up another set of images from the start and it would progress them through.

Right now you have to click cancel because the workflow never "Completes" and is always stuck in the queue until you cancel.

Could also help with memory management like I mentioned in https://github.com/chrisgoringe/cg-image-picker/issues/63