search

chrisgoringe / cg-image-picker

198 stars 13 forks source link

"Restart with selected" should override "Take n" #69

Closed Immac closed 3 months ago

Immac commented 6 months ago

When the node is in "Take n" mode, if you restart, it'll ignore your choices, when the workflow is working automatically "Take n" works fine, but if it's a restart and I'm choosing a set of pictures it's a given that I want the images I chose to be used and not the n images of the "Take n".

chrisgoringe commented 5 months ago

Need to know why you are using "take n", I think it's a fairly rare use so I'm unlikely to work on fixing it.

Immac commented 5 months ago

Need to know why you are using "take n", I think it's a fairly rare use so I'm unlikely to work on fixing it.

Usually I use it to take 1 and let it follow the process, but I generate a few more, so if I like another one I can select that one and send it, so my usual workflow is take 1 but sometimes I like another one and want to send it, but I have to change it to bypass because if I don't it just takes the first one again.,

Immac commented 4 months ago

Need to know why you are using "take n", I think it's a fairly rare use so I'm unlikely to work on fixing it.

image image

Let's say I want to choose between two parts of the process, I by default take the first one, but let's say I want sometimes to use the other picture, click "using selected as re-start" should do exactly that, use the selected ones as a restart, not take the first one again.

chrisgoringe commented 4 months ago

OK, that might make sense... I'd be inclined to say run the workflow again with the same seeds, though.

Immac commented 4 months ago

OK, that might make sense... I'd be inclined to say run the workflow again with the same seeds, though.

If the workflow is stochastic you can't guarantee the same picture, also for consistency, the button is "Selected as Restart", not "Do again"