Closed filliptm closed 4 months ago
yeah I second that, everytime I click queue prompt, i have to reselect things from the begining, and it kept re-run thing that I have selected for some wierd reason... So far I have to go back to "select Latent from batch" to do a smooth workflow...This workflow is awesome! Really wish it can remember the cache!
this was my half ass solution to replace image picker to prevent it re-run the whole calculation
Sorry, I don't understand what's being asked for here? Can someone describe:
(a) what you do (b) what currently happens (c) what you would like to happen
And, if possible, provide the simplest possible workflow that illustrates the problem
Put simply, we'd like the node to have a memory of what you've already selected. If nothing changes down the workflow, like seed or settings, the node in its current state still requires you to select a choice. We'd like to the node to remember your choice if i hit que again and nothing has changed up to the preview chooser node
that way when we click que again we do not have to select an image in the node over and over
But what if you want to repeat the lower part of the workflow with a different selection?
i dont think re running the ksampler is a bad trade off. That or add a toggle on the node itself, what ever solution you think is best, but as it stands your node is unusable in larger workflows for the reason that it doesnt hold a memory at all of selection. In my humble opinion
Really? Having to rerun the upstream section (which might be much more than just a ksampler) is better than having to click an image? I'm obviously not understanding the problem (doesn't help that you haven't actually shared a workflow or screenshot or anything like that...)
thats what im saying. if your node is anywhere near the beginning, regardless of size of flow afterwords, EVERYTHING has to rerun after the node, if i want to select a new image starting from your node, i dont think its unreasonable to rerun that section if i want a new choice imo, as your going to have to rerun everything afterwords anyway
iv basically had to ditch using the node because i cant tweak things down stream without selecting every time i hit que, even tho my choices are locked in my decision
Let me see if I understand - the problem isn't that you need to click the images in the image chooser node again, it's that nodes downstream of the chooser have to rerun even though they are getting the same input (because the chooser node reruns).
OK, that makes sense.
So if I could add an option (maybe "Resend previous output") that, as long as nothing upstream of the chooser had changed, would prevent the chooser from running (and treat it as unchanged), would that solve the problem?
correct, thats the issue
yeah that would be perfect! i know a lot of people will be happy with that added feature
I just pushed an update that I think does what you want - select repeat last selection
as the mode.
If there is no previous selection, or if anything upstream has changed, it acts as if it were Always pause
. But if there are no upstream changes, it is marked as not changed.
Hopefully ComfyUI will take care of the rest.
Hello! Thank you Chris for this fast update! Its working great for having one image chooser only so far, but if two are added, only the very first image chooser working, if the second one has a different setting than the first chooser, It will not work and no image being previewed.... Hopefully this can support multi-chooser in one workflow, this will be amazing!! Thank you in advance!
try it now
try it now
'Repeat last selection' works for me now across a chain of 3 preview chooser
Thank you very much for adding this! I couldn't figure out why my ComfyUI cache was being invalidated downstream even when I picked the same images in the Image Chooser. The Repeat Last Selection mode works much better.
can we have the picker node hold the cache of what you previously picked? having to select the images every time you run the workflow REALLY bogs things down, especially if you workflow is large and the node is near the beginning, it forces the whole workflow after to have to be rerun every time