Simplify the UE? autocomplete layout

[JorgeR81]

The UE? node looks good now. But I think the design is more complex than what's necessary, which could increase the probability of bugs.

Can't you just use the original ( vanilla ) fields ? Do you really need to redraw some different fields on top of the node ?

If this is just to show the triangle arrow facing down, on mouseover, I don't think it's necessary. And if the balloon arrow don't exactly match each vanilla field height position, just remove the arrow part from the balloon.

We also don't have this for the vanilla fields, and it's OK. We don't have a visual indicador, when we mouseover vanilla fields.  And when we click on a vanilla field and see the input textbox, we are supposed to know the field where we clicked, to which the textbox refers to.

These UE? custom features are nice, but will never be a perfect match for the rest of Comfy UI visuals. For instance, the custom fields are still in front of the input textbox.

[chrisgoringe]

Can't you just use the original ( vanilla ) fields?

Not really. The original fields are ComfyUI Text Widgets, not HTML elements. The autocomplete uses the built-in HTML tools rather than writing a custom one - so it greatly reduces the danger of bugs :).

That said, it might be possible to use the text edit popup (not at all sure of that). If not, I can at least add a visual indication of the field being edited.

[JorgeR81]

OK, I see. The vanilla text edit popup is still usable. You just need to move the workflow a bit, to get the custom fields out the way.

[chrisgoringe]

Take a look at it now and see what you think

[JorgeR81]

This is an extra click, but I actually like it more this way.

It gives larger text to type, so it's easier to focus on that.
It allows a better interaction between typing ( or deleting characters ) and clicking on the autocomplete options that became available.

But, it's the final goal to get rid of the custom fields ? They are still in the front of their own text edit popup, sometimes.

[chrisgoringe]

That’s weird. I’ve never seen that happen!

On Wed, 13 Mar 2024 at 9:26 pm, JorgeR81 @.***> wrote:

This is an extra click, but I actually like it more this way.

It gives larger text to type. I think it allows a better interaction between typing ( or deleting characters ) and the autocomplete options that became available.

But, it's the final goal to get rid of the custom fields ? They are still in the front of their own front textbox, sometimes.

test1.jpg (view on web) https://github.com/chrisgoringe/cg-use-everywhere/assets/72734038/c064bf59-17ed-4923-aa73-88c91f314f37

— Reply to this email directly, view it on GitHub https://github.com/chrisgoringe/cg-use-everywhere/issues/134#issuecomment-1994051308, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBLMA3CHRRPS2FGRJDBDKLYYASVZAVCNFSM6AAAAABETA5A4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGA2TCMZQHA . You are receiving this because you commented.Message ID: @.***>

[JorgeR81]

For me, it only seems to work correctly when the UE? nodes are not highlighted. Or if the highlight is on a different node.

[chrisgoringe]

Take a look now.

Incidentally, it looks like there is an underlying Comfy issue here as well:

[chrisgoringe]

I'm going to close this issue and will open more specific ones for any outstanding issues.

[JorgeR81]

It seems to be working. But only if I create a new workflow with this version. I still have that issue with old workflows, even if I replace the UE? nodes. Is that to be expected ? ( For me it's OK, I can recreate my workflows ).

---

I also noticed some minor issues, since the spurious text box was fixed. It still shows up in some scenarios:

1) If a minimized UE? node is cloned. In this case it goes away when the node is maximized. It never shows up again, even if the node is minimized again. This is a minor issue, since the cloned UE? node needs to be maximized anyways, to make connections. If I reload the page, and then pan / zoom the worflow a bit, it also goes away.

2) If I copy UE? nodes ( Crtl+C ), even if maximized. If I reload the page, and then pan / zoom the worflow a bit, it also goes away.

3) If save a template with UE? nodes, even if maximized. If I reload the page, and then pan / zoom the worflow a bit, it also goes away.

4) If I load a template with minimized UE? nodes. It's also fixed by maximizing and minimizing all of them, but it's a bit more annoying. If I reload the page, and then pan / zoom the worflow a bit, it also goes away.

5) If I open a worflow with minimized UE nodes. This only happens sometimes and it goes away if I pan / zoom a bit.
No need to reload the page in this case.

---

it looks like there is an underlying Comfy issue here as well

Yes, I already had that issue before using UE nodes.

But in this image, I also noticed another artifact, in bypassed UE? nodes, with transparency. Also a minor issue, since, were not going to put nodes on top of each other.

[JorgeR81]

Using the built-in HTML autocomplete was a good idea. But if all these related visual artifacts become too much trouble, you can always try a custom autocomplete.

This autocomplete seems to be working fine, and it's MIT.

https://github.com/pythongosssss/ComfyUI-Custom-Scripts/blob/main/web/js/common/autocomplete.js