search

chrisgoringe / cg-use-everywhere

Apache License 2.0
349 stars 28 forks source link

[Bug] A compatibility issue with Custom Scripts makes text disappear #151

Open LukeG89 opened 3 months ago

LukeG89 commented 3 months ago

After disabling your custom node, I found the main cause of a bug that was bothering me for months.

I think there is a compatibility issue between UE and pythongosssss/ComfyUI-Custom-Scripts.

I have reported this issue on another custom node (workspace manager), because I thought it was causing the problem: https://github.com/11cafe/comfyui-workspace-manager/issues/245#issue-2172534709

This is the specific bug: https://github.com/11cafe/comfyui-workspace-manager/issues/245#issuecomment-1985621736

The bug goes away only if I disable Custom Scripts or UE.

JorgeR81 commented 3 months ago

I have [ ComfyUI-Custom-Scripts ] but not [ comfyui-workspace-manager ]

I never noticed that issue.

Maybe it's also an interaction with another node. See if you have something I don't:

LukeG89 commented 3 months ago

@JorgeR81 Thanks for your help! It's hard to say, I have a ton of nodes installed... 😅

Excluding yours, this is what I also have:

I can exclude the most recent ones from the list, but I can't remember when this bug has started popping out. I don't even know what could be the cause, but for some reason UE is involved.

At least it's not an important issue, even though you can have an heart attack when your prompt has suddenly disappeared! 😬

LukeG89 commented 3 months ago

Just tried disabling every single node, one by one, remaining only with Manager, Custom Scripts and UE.

But the bug is still present:

https://github.com/chrisgoringe/cg-use-everywhere/assets/161304036/241a9f19-cb63-479b-ad7a-c7ab881524b3

And as I said before, if I disable one of these two nodes, the bug is gone. I don't know why.

JorgeR81 commented 3 months ago

Maybe it's something in the settings in one of these nodes. This is what I have.

set

LukeG89 commented 3 months ago

I already tried disabling everything, nothing changed 😞

JorgeR81 commented 3 months ago

Try to uninstall 1 of these 2 and install again, instead of just disabling them.

chrisgoringe commented 3 months ago

Also worth going into ComfyUI/web/extensions and removing everything in there except for core. Do not delete core!

The old way of doing custom javascript (still used by many nodes) was to copy it into that folder. But then it often doesn't disappear even if the custom node is deleted. Then you find custom nodes can still do stuff even from the grave!

If you delete something that a custom node uses, it will put it back, so no harm removing it.

chrisgoringe commented 3 months ago

Also worth trying - look at the Javascript console after you've done the load that was broken (press f12) and see if there is a message of any sort hinting at the issue.

LukeG89 commented 3 months ago

Tried everything you said: reinstalling both nodes, deleting folders from extension, also tried uninstalling other nodes that creates a folder inside extension (FizzNodes, Dave CustomNode and 3D Pose Editor), but didn't solve anything.

LukeG89 commented 3 months ago

Here's the javascript console: javascript_console

The console doesn't change if I enable/disable UE node, but the bug disappears when disabling it.

JorgeR81 commented 3 months ago

After so much trouble, you might as well try a new fresh install of Comfy UI.

That should fix it, for sure, right ?

Unless this is something related to your browser ...

JorgeR81 commented 3 months ago

If you have the SSD space you could try a new portable install, without deleting the previous one.

I have 2 portable installs. One of them only has "vanilla" functionally, and I use it as "backup".