chrisgoringe / cg-use-everywhere

Apache License 2.0
471 stars 33 forks source link

UE Nodes breaks Efficient Nodes #182

Closed gonzalu closed 5 months ago

gonzalu commented 5 months ago

Hello,

I noticed that the UE Nodes package causes one of the functions of the Efficient Nodes package to break. The RANDOM SEED function gets reset immediately after pressing random.

Problem only occurs after installing UE nodes.

Thank you for looking into it if possible

P.S. I also posted on the Efficient Nodes (JAGS111) GitHub Repo

https://github.com/chrisgoringe/cg-use-everywhere/assets/32348862/a769ad7a-b848-41f6-bb3b-fada31830e81

BliNDF123 commented 5 months ago

I mentioned this issue back in February, but a mistake on my part of an 'Everywhere' node which I was using wrong which he tells me this and doesn't say anything about the same issue you've recorded here which I also described. You've probably noticed you can click on any node, not only UE nodes and Efficiency nodes, all of them. I was just TRYING Seed Everywhere, and that's what seemed to bug mine out. Click anywhere in the ComfyUI window now and it will keep doing a random seed, very annoying, had to uninstall at that point as it was unusable.

chrisgoringe commented 5 months ago

Hi, I've just posted a fix (I believe) for this issue. Update the UE nodes and try again.

novaexe commented 5 months ago

Hi, I've just posted a fix (I believe) for this issue. Update the UE nodes and try again.

confirmed fixed

gonzalu commented 5 months ago

Hi, I've just posted a fix (I believe) for this issue. Update the UE nodes and try again.

Looks like it fixed the issue with the Efficient nodes... however, I lost the glowing outlines on inputs and also Show UE links are no longer showing.

Did I miss something in the settings perhaps? Making sure it is not user error. I only UPDATED ComfyUI and Extensions via Manager. Thanks Chris!!

chrisgoringe commented 5 months ago

Could you look at the JavaScript console (f11) and see if there are any error messages?

gonzalu commented 5 months ago

So sorry for the delay in responding, Chris.

Looks like it may have been a fluke... I literally cleared the workspace and loaded a new workflow to do something else, and lo and behold, the christmas lights and the magic glowing circles were back ... go figure.

P.S. functionality never suffered... it was still sending stuff through the workflow it was just the visuals.

Maybe it just needed a kick.